Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1471 - No sorting for two-points convex hull #1472

Merged
merged 4 commits into from
Jun 30, 2019
Merged

#1471 - No sorting for two-points convex hull #1472

merged 4 commits into from
Jun 30, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Jun 25, 2019

Closes #1471.

Requires: #1484.


I hesitated to keep the current version and use dispatch on values, and finally decided against it. If we have an application that requires sorting, it is easy to reimplement it.

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests need to be fixed.

test/unit_convex_hull.jl Outdated Show resolved Hide resolved
@mforets mforets merged commit 1b99190 into master Jun 30, 2019
@mforets mforets deleted the mforets/1471 branch June 30, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2-point convex hull shouldn't sort vertices by default
2 participants